Miretpl commented on code in PR #59730:
URL: https://github.com/apache/airflow/pull/59730#discussion_r2646335671
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -62,8 +62,12 @@ spec:
serviceName: {{ include "airflow.fullname" . }}-worker
{{- end }}
{{- if and (not $keda) (not $hpa) }}
+ {{- if ne (int .Values.workers.celery.replicas) 1 }}
Review Comment:
The original thinking behind the current logic was to preserve the default
config, but in the mentioned case, the behaviour is unintuitive. At first, I
thought that this behaviour was okay-ish, but now I think that we should go
with null as a default for `workers.celery.replicas` field (but it will
probably require remembering to set the default for this setting with the 2.0
release and removal of deprecated option). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
