Miretpl commented on code in PR #59730:
URL: https://github.com/apache/airflow/pull/59730#discussion_r2651892182
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -62,8 +62,12 @@ spec:
serviceName: {{ include "airflow.fullname" . }}-worker
{{- end }}
{{- if and (not $keda) (not $hpa) }}
+ {{- if ne (int .Values.workers.celery.replicas) 1 }}
Review Comment:
Do you mean something like:
```
replicas: {{ .Values.workers.celery.replicas | default
.Values.workers.replicas }}
```
if yes, than this situation where `.Values.workers.celery.replicas` is
`null` will not happen as in `values.schema.json` we have (required integer
type):
```json
"replicas": {
"description": "Number of Airflow Celery workers.",
"type": "integer",
"default": 1
}
```
and also it would change the behaviour of the chart. If someone has the
`.Values.workers.replicas=3`, after upgrading to the new version, this value
would change to `1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
