Miretpl commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2648312035
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -95,11 +95,22 @@ spec:
{{- if $containerLifecycleHooks }}
lifecycle: {{- tpl (toYaml $containerLifecycleHooks) . | nindent 12
}}
{{- end }}
- {{- if .Values.statsd.args }}
- args: {{ tpl (toYaml .Values.statsd.args) . | nindent 12 }}
- {{- else}}
args:
- - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
+ {{- if .Values.statsd.cache.size }}
+ - "--statsd.cache-size={{ .Values.statsd.cache.size }}"
+ {{- end }}
+ {{- if .Values.statsd.cache.type }}
+ - "--statsd.cache-type={{ .Values.statsd.cache.type }}"
+ {{- end }}
+ {{- if .Values.statsd.cache.ttl }}
+ - "--ttl={{ .Values.statsd.cache.ttl }}"
+ {{- end }}
+ {{- if .Values.statsd.args }}
+ {{- range $arg := .Values.statsd.args }}
+ - {{ $arg | quote }}
+ {{- end }}
Review Comment:
@shubham36deshpande I mentioned `statsd.cache.enabled` (it does not exist in
the current version, but it replicates the behaviour of `statsd.cache` flag
from the first version of the PR), not `statsd.enabled`. As you mentioned,
people might want to have statsd enabled without cache (it is also for
preserving backward compatibility). In the first version of the PR, when we had
the `statsd.cache` flag for it (btw. it is still mentioned in the newsfragment
file) it was easier to do and I think that when we have the `statsd.cache`
section now, it would be beneficial to add a flag for it e.g.
`statsd.cache.enabled` with default `false` value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
