jscheffl commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2649770673
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -62,13 +62,13 @@ spec:
component: statsd
release: {{ .Release.Name }}
{{- if or .Values.labels .Values.statsd.labels }}
- {{- mustMerge .Values.statsd.labels .Values.labels | toYaml |
nindent 8 }}
+ {{- mustMerge .Values.statsd.labels .Values.labels | toYaml | nindent
8 }}
Review Comment:
This change (as well as line 71) seems to be unrelated. Pleas revert this.
##########
chart/values.yaml:
##########
@@ -2407,6 +2407,37 @@ statsd:
# Arguments for StatsD exporter command.
args: ["--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"]
+ # If you ever need to fully override the entire args list, you can
Review Comment:
Here is still some white space inconsistency
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -95,11 +95,22 @@ spec:
{{- if $containerLifecycleHooks }}
lifecycle: {{- tpl (toYaml $containerLifecycleHooks) . | nindent 12
}}
{{- end }}
- {{- if .Values.statsd.args }}
- args: {{ tpl (toYaml .Values.statsd.args) . | nindent 12 }}
- {{- else}}
args:
- - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
+ {{- if .Values.statsd.cache.size }}
+ - "--statsd.cache-size={{ .Values.statsd.cache.size }}"
Review Comment:
Indent is incorrect here, lists should be indented by two spaces on top of
the dash. Please apply also to the ones below.
```suggestion
- "--statsd.cache-size={{ .Values.statsd.cache.size }}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
