amoghrajesh commented on code in PR #59912:
URL: https://github.com/apache/airflow/pull/59912#discussion_r2652335798
##########
task-sdk/src/airflow/sdk/definitions/_internal/abstractoperator.py:
##########
@@ -76,7 +76,8 @@
DEFAULT_TASK_EXECUTION_TIMEOUT: datetime.timedelta | None = conf.gettimedelta(
"core", "default_task_execution_timeout"
)
-
+DEFAULT_EMAIL_ON_FAILURE: bool = conf.getboolean("email",
"default_email_on_failure", fallback=True)
+DEFAULT_EMAIL_ON_RETRY: bool = conf.getboolean("email",
"default_email_on_retry", fallback=True)
Review Comment:
We should have some test coverage for this. The test:
`test_default_email_on_actions` only checks for true. Maybe use `conf_vars` to
explicitly set to false and assert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
