justinpakzad commented on code in PR #59912:
URL: https://github.com/apache/airflow/pull/59912#discussion_r2653344811
##########
task-sdk/src/airflow/sdk/definitions/_internal/abstractoperator.py:
##########
@@ -76,7 +76,8 @@
DEFAULT_TASK_EXECUTION_TIMEOUT: datetime.timedelta | None = conf.gettimedelta(
"core", "default_task_execution_timeout"
)
-
+DEFAULT_EMAIL_ON_FAILURE: bool = conf.getboolean("email",
"default_email_on_failure", fallback=True)
+DEFAULT_EMAIL_ON_RETRY: bool = conf.getboolean("email",
"default_email_on_retry", fallback=True)
Review Comment:
So I've been trying to add some tests using `conf_vars` but I'm running into
some issues. The issue (I think) is that the email defaults are read as
module-level constants at import time, so using `conf_vars` requires reloading
the modules to pick up config changes. But when I do that, it causes other test
files that have already imported operators (which inherit from the original
BaseOperator) to fail. Do you know if there are any workarounds for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
