shahar1 commented on code in PR #60052:
URL: https://github.com/apache/airflow/pull/60052#discussion_r2658852992
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -193,7 +193,8 @@ def __init__(
self.skip_when_already_exists = skip_when_already_exists
self.fail_when_dag_is_paused = fail_when_dag_is_paused
self.openlineage_inject_parent_info = openlineage_inject_parent_info
- self.deferrable = deferrable
+ # deferrable only makes sense when wait_for_completion=True
+ self.deferrable = deferrable and wait_for_completion
Review Comment:
If it only makes sense when `wait_for_completion = True`:
1. It should raise an exception when it's not (inc. reasoning + suggestion
for fixing actions)
2. The exception should be tested
3. It should be documented in the docstring (for both parameters)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
