nathadfield commented on code in PR #60052:
URL: https://github.com/apache/airflow/pull/60052#discussion_r2660871387
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -193,7 +193,8 @@ def __init__(
self.skip_when_already_exists = skip_when_already_exists
self.fail_when_dag_is_paused = fail_when_dag_is_paused
self.openlineage_inject_parent_info = openlineage_inject_parent_info
- self.deferrable = deferrable
+ # deferrable only makes sense when wait_for_completion=True
+ self.deferrable = deferrable and wait_for_completion
Review Comment:
Looking again, I think the actual issue is in `task_runner.py` as it seems
to
[check](https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/execution_time/task_runner.py#L1292-L1310)
`deferrable` BEFORE checking `wait_for_completion`. I'll fix that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
