potiuk commented on code in PR #60062:
URL: https://github.com/apache/airflow/pull/60062#discussion_r2661348820
##########
providers/apache/impala/src/airflow/providers/apache/impala/hooks/impala.py:
##########
@@ -16,15 +16,28 @@
# under the License.
from __future__ import annotations
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Type
from impala.dbapi import connect
-from sqlalchemy.engine import URL
+from airflow.exceptions import AirflowOptionalProviderFeatureException
from airflow.providers.common.sql.hooks.sql import DbApiHook
if TYPE_CHECKING:
from impala.interface import Connection
+ from sqlalchemy.engine import URL
+
+
+def _get_sqlalchemy_url_class() -> Type["URL"]:
Review Comment:
One nit: can we inline this function? I think it's a bit excessive to have
it as a separate function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
