potiuk commented on code in PR #60062:
URL: https://github.com/apache/airflow/pull/60062#discussion_r2665512748
##########
providers/apache/impala/pyproject.toml:
##########
@@ -78,7 +81,8 @@ dev = [
"apache-airflow-providers-common-sql",
# Additional devel dependencies (do not remove this line and add extra
development dependencies)
"kerberos>=1.3.0",
- "apache-airflow-providers-common-sql[pandas,polars]"
+ "apache-airflow-providers-common-sql[pandas,polars]",
+ "apache-airflow-providers-apache-impala[sqlalchemy]",
Review Comment:
> since we are adding SQLAlchemy to the optional dependencies, why are we
also adding SQLAlchemy here ?
Because we want to run complete set of tests with "all' dependencies -
including the optional ones- this is a "dev" depenency group, which means that
those dependencies will be automatically installed when you run `uv sync` and
subsequently run `uv run pytest` to run all test cases (for example). It only
impacts development environment when you are developing this provider and want
to run tests.
we could also add `sqlalchemy>=1.49.1` here - but by adding it this way we
only need to keep the min version in one place - in the optional deps - and dev
dependencies will use it from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
