vatsrahul1001 commented on PR #59734:
URL: https://github.com/apache/airflow/pull/59734#issuecomment-3713152037
@haseebmalik18 Thanks for working on this! Few things to address:
1. **Boolean return methods** - Methods like `isAuditLogTableVisible()` that
catch errors and return `false` make debugging hard. Use Playwright assertions
directly instead.
2. **Data validation** - The current check just verifies "something exists".
Better to verify actual content - event types (dag_triggered, created, etc.)
and date formats.
3. **Sorting** - Currently only checks that order changed, not that it's
sorted correctly. Verify the actual sort direction.
4. **DagsPage changes** - Why was `waitForDagList()` removed? Seems
unrelated to audit log tests. Please revert or explain.
5. **Pagination** - You can use the `limit` URL param to force smaller page
size:
`/dags/{dagId}/events?limit=3`
This way 4 events will trigger pagination (3 on page 1, 1 on page 2).
Just update `navigateToAuditLog` to accept an optional limit parameter.
Let me know if you have questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
