vatsrahul1001 commented on code in PR #59734: URL: https://github.com/apache/airflow/pull/59734#discussion_r2675665488
########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-audit-log.spec.ts: ########## @@ -0,0 +1,163 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { expect, test } from "@playwright/test"; +import { AUTH_FILE, testConfig } from "playwright.config"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; +import { EventsPage } from "tests/e2e/pages/EventsPage"; + +test.describe("DAG Audit Log", () => { + let eventsPage: EventsPage; + + const testDagId = testConfig.testDag.id; + const triggerCount = 3; + const expectedEventCount = triggerCount + 1; + + test.setTimeout(60_000); + + test.beforeAll(async ({ browser }) => { + test.setTimeout(3 * 60 * 1000); + const context = await browser.newContext({ storageState: AUTH_FILE }); + const page = await context.newPage(); + const setupDagsPage = new DagsPage(page); + const setupEventsPage = new EventsPage(page); + + for (let i = 0; i < triggerCount; i++) { + await setupDagsPage.triggerDag(testDagId); + } + + await setupEventsPage.navigateToAuditLog(testDagId); + await page.waitForFunction( + (minCount) => { + const table = document.querySelector('[data-testid="table-list"]'); + + if (!table) { + return false; + } + const rows = table.querySelectorAll("tbody tr"); + + return rows.length >= minCount; + }, + expectedEventCount, + { timeout: 60_000 }, + ); + + await context.close(); + }); + + test.beforeEach(({ page }) => { + eventsPage = new EventsPage(page); + }); + + test("should navigate to audit log tab and display table", async () => { + await eventsPage.navigateToAuditLog(testDagId); + + await expect(eventsPage.eventsTable).toBeVisible(); + + const rowCount = await eventsPage.tableRows.count(); + + expect(rowCount).toBeGreaterThan(0); + }); + + test("should display all expected columns in audit log table", async () => { Review Comment: rename test to `verify expected columns are visible` ########## airflow-core/src/airflow/ui/tests/e2e/specs/dag-audit-log.spec.ts: ########## @@ -0,0 +1,163 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { expect, test } from "@playwright/test"; +import { AUTH_FILE, testConfig } from "playwright.config"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; +import { EventsPage } from "tests/e2e/pages/EventsPage"; + +test.describe("DAG Audit Log", () => { + let eventsPage: EventsPage; + + const testDagId = testConfig.testDag.id; + const triggerCount = 3; + const expectedEventCount = triggerCount + 1; + + test.setTimeout(60_000); + + test.beforeAll(async ({ browser }) => { + test.setTimeout(3 * 60 * 1000); + const context = await browser.newContext({ storageState: AUTH_FILE }); + const page = await context.newPage(); + const setupDagsPage = new DagsPage(page); + const setupEventsPage = new EventsPage(page); + + for (let i = 0; i < triggerCount; i++) { + await setupDagsPage.triggerDag(testDagId); + } + + await setupEventsPage.navigateToAuditLog(testDagId); + await page.waitForFunction( + (minCount) => { + const table = document.querySelector('[data-testid="table-list"]'); + + if (!table) { + return false; + } + const rows = table.querySelectorAll("tbody tr"); + + return rows.length >= minCount; + }, + expectedEventCount, + { timeout: 60_000 }, + ); + + await context.close(); + }); + + test.beforeEach(({ page }) => { + eventsPage = new EventsPage(page); + }); + + test("should navigate to audit log tab and display table", async () => { Review Comment: rename test to `verify audit log table displays` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
