vatsrahul1001 commented on PR #59754:
URL: https://github.com/apache/airflow/pull/59754#issuecomment-3713690469
@Sahil-Shadwal Thanks for working on this! A few things to address:
1. **Move DAG trigger to `beforeAll`** - Running in `beforeEach` is too slow
(6 triggers for 6 tests). Create runs with different states for proper
testing(this will help in filtering tet)
You can change dag run success state to failed state with patch call
```
await page.request.patch(
`/api/v1/dags/${testDagId}/dagRuns/${runId}`,
{ data: { state: "failed" } }
```
3. **Create separate `dag-runs.spec.ts`** - Don't add to `dags-list.spec.ts`
4. **Filter test improvement** - Currently filters by a state that already
exists. Either create runs with mixed states, or use the API to mark a run as
failed to properly test filtering we can do it in before all
5. **Pagination** - Use `?offset=0&limit=1` URL param to test pagination
without needing many runs
6. **Search test** - Search for a partial pattern and verify fewer results
returned
7. **Verify `waitForPageLoad`** - Make sure it exists in BasePage or use
`waitForLoadState("networkidle")`
8. You need to rebase
Let me know if you have questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
