dabla commented on PR #58498: URL: https://github.com/apache/airflow/pull/58498#issuecomment-3713843013
Hello @TyrellHaywood , I would try to reuse the KiotaRequestAdapterHook from msgraph module, so your AzureAnalysisServicesHook would extend the KiotaRequestAdapterHook instead of BaseHook. That way you don't need to re-invent the wheel regarding security related stuff (e..g handling the access token and so on). The PowerBIHook for example also extends the KiotaRequestAdapterHook, that way your hook will become much simpler and code will be more DRY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
