dabla commented on code in PR #58498: URL: https://github.com/apache/airflow/pull/58498#discussion_r2665208986
########## providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/analysis_services.py: ########## @@ -0,0 +1,288 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import time +from typing import Any + +import requests +from azure.identity import ClientSecretCredential, DefaultAzureCredential + +from airflow.exceptions import AirflowException +from airflow.providers.common.compat.sdk import BaseHook +from airflow.providers.microsoft.azure.utils import ( + add_managed_identity_connection_widgets, + get_field, + get_sync_default_azure_credential, +) + + +class AzureAnalysisServicesRefreshStatus: Review Comment: Hello @TyrellHaywood , I would try to reuse the KiotaRequestAdapterHook from msgraph module, so your AzureAnalysisServicesHook would extend the KiotaRequestAdapterHook instead of BaseHook. That way you don't need to re-invent the wheel regarding security related stuff (e..g handling the access token and so on). The PowerBIHook for example also extends the KiotaRequestAdapterHook, that way your hook will become much simpler and code will be more DRY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
