houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid
unnecessary sleep to maintain local task job heart rate
URL: https://github.com/apache/airflow/pull/6553#discussion_r352749458
##########
File path: airflow/jobs/local_task_job.py
##########
@@ -112,13 +111,6 @@ def signal_handler(signum, frame):
"exceeded limit ({}s)."
.format(time_since_last_heartbeat,
heartbeat_time_limit))
-
- if time_since_last_heartbeat < self.heartrate:
Review comment:
heartbeat already has this check to maintain the heart rate, so this logic
is redundant for all `heartbeat()` callers. It's safe to just remove it :) The
test covers this to make sure heart rate is still maintained without this check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
