houqp commented on a change in pull request #6553: [AIRFLOW-5902] avoid
unnecessary sleep to maintain local task job heart rate
URL: https://github.com/apache/airflow/pull/6553#discussion_r352750606
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -43,6 +43,9 @@
class TestLocalTaskJob(unittest.TestCase):
def setUp(self):
clear_db_runs()
+ patcher = patch('airflow.jobs.base_job.sleep')
Review comment:
yeah, this test doesn't cover the code path that does the actual sleep call
in those two classes. we should definitely patch them if a test runs through
those code path going forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
