vatsrahul1001 commented on PR #59943:
URL: https://github.com/apache/airflow/pull/59943#issuecomment-3714220560
@RavinduWeerakoon Thanks for the PR! Good structure and use of data-testid.
Here's feedback:
1. **Add DAG trigger in `beforeAll`** - Need to run the DAG to test "Last
Instance" column with actual status data
2. **Add test for Last Instance column** - Verify timestamp and status badge
are displayed correctly
3. **Test status colors** - Verify success (green) and skip status display
correctly (`example_bash_operator` has skipped tasks)
4. **Use config for DAG ID** - Replace hardcoded `"example_bash_operator"`
with `testConfig.testDag.id`
5. **Test names** - Use "verify" prefix: `verify tasks tab displays list`,
`verify search filters tasks`, etc.
6. **Fix retries test** - Remove conditional `if/else` logic - makes test
non-deterministic
7. **Fix active tab check** - `toHaveAttribute("class", "active")` is
fragile. Use `toHaveURL(/\/tasks$/)` instead
8. **Add page load wait** - `navigateToDagTasks` should wait for tasks to
load before returning
9. **Remove default parameter** - `navigateToDagTasks(dagId: string =
"...")` should not have a default
Let me know if you have questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
