Lee-W commented on code in PR #60006:
URL: https://github.com/apache/airflow/pull/60006#discussion_r2667386640
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -3020,7 +2975,7 @@ def _try_to_load_executor(self, ti: TaskInstance,
session, team_name=NOTSET) ->
return executor
- def _exceeds_max_active_runs(
+ def _check_exceeds_max_active_runs(
Review Comment:
```suggestion
def _set_exceeds_max_active_runs(
```
set... might make more sense here? We're not actually checking . We just set
the value here
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1790,6 +1789,14 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
)
for dag_model in dag_models:
+ if dag_model.exceeds_max_non_backfill:
+ self.log.error(
Review Comment:
Should it be a warning instead? Since max active runs is set by users, it's
kinda expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
