dstandish commented on code in PR #60006:
URL: https://github.com/apache/airflow/pull/60006#discussion_r2669219575
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -3020,7 +2975,7 @@ def _try_to_load_executor(self, ti: TaskInstance,
session, team_name=NOTSET) ->
return executor
- def _exceeds_max_active_runs(
+ def _check_exceeds_max_active_runs(
Review Comment:
i think check actually makes sense because, we are checking whether it is
exceeded; and if it is exceeded, then we set it to the right value. you can't
set without that "check" part first.
To me, `set` sort of implies we already know, and we are setting it to
`exceeds=True`.
I think `evaluate` might be an even better word, but it's so long i kindof
think check is better. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
