kaxil commented on code in PR #60052:
URL: https://github.com/apache/airflow/pull/60052#discussion_r2670002425
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -1289,25 +1289,25 @@ def _handle_trigger_dag_run(
# be used when creating the extra link on the webserver.
ti.xcom_push(key="trigger_run_id", value=drte.dag_run_id)
- if drte.deferrable:
- from airflow.providers.standard.triggers.external_task import
DagStateTrigger
-
- defer = TaskDeferred(
- trigger=DagStateTrigger(
- dag_id=drte.trigger_dag_id,
- states=drte.allowed_states + drte.failed_states, # type:
ignore[arg-type]
- # Don't filter by execution_dates when run_ids is provided.
- # run_id uniquely identifies a DAG run, and when
reset_dag_run=True,
- # drte.logical_date might be a newly calculated value that
doesn't match
- # the persisted logical_date in the database, causing the
trigger to never find the run.
- execution_dates=None,
- run_ids=[drte.dag_run_id],
- poll_interval=drte.poke_interval,
- ),
- method_name="execute_complete",
- )
- return _defer_task(defer, ti, log)
if drte.wait_for_completion:
Review Comment:
Good catch @nathadfield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
