dabla commented on PR #60152:
URL: https://github.com/apache/airflow/pull/60152#issuecomment-3723856131

   > Looks good and seems it would be great to have it in 3.1.6 - but I would 
love someone with more triggerer expertise reviews it.
   
   Agreed.
   
   Some small explanation of what the code does:
   
   Now before the completed events are being send through the comms supervisor, 
it will first try to encode each event individually, if that succeeds, then the 
event is considered valid, otherwise it will be considered as failed and thus 
the trigger will also be considered as a failed trigger due to the fact that it 
returned a TriggerEvent which contains an non-serializable payload.  The 
drawback is duplicate encoding, once per event and then on the whole message at 
the end which was originally also the case, but that's the only way I found to 
be able to detect which event could be the culprit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to