Dev-iL opened a new pull request, #60270:
URL: https://github.com/apache/airflow/pull/60270

   ### Context
   When using DAG bundles (particularly Git bundles) with user impersonation 
(`run_as_user`), tasks can fail due to permission conflicts. The root cause is 
that bundles are initialized by the main airflow user BEFORE impersonation 
happens, but the impersonated user later needs access to bundle resources like 
lock files and tracking directories.
   
   #### Specific issues encountered:
   
   1. Lock files created with restrictive permissions block impersonated users
   1. Tracking directories inaccessible to impersonated users
   1. Git's "dubious ownership" error when different users access the same 
repository
   
   ### Changes
   This PR provides the foundation for fixing impersonation + bundle permission 
issues:
   
   1. Configuration options allow users to customize permissions based on their 
environment
   1. Default group-writable permissions (775/664) work out-of-the-box for 
environments where the airflow user and impersonated users share a common group
   1. Lock and tracking files are now created with appropriate permissions, 
eliminating the most common permission errors
   1. Mirrors existing patterns - similar to `[logging] 
file_task_handler_new_file_permissions` which solves the same problem for log 
files
   
   #### Related Changes (follow-up PRs)
   This is part 1 of 3 PRs to fully address the impersonation + bundles issue:
   
   1. PR 1 (this one): airflow-core - Add permission configuration and apply to 
lock/tracking files
   1. PR 2: providers/git - Apply permissions to cloned repositories and 
configure git safe.directory
   1. PR 3: task-sdk - Add startup warning when permissions may cause 
impersonation issues
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to