Dev-iL commented on code in PR #60270:
URL: https://github.com/apache/airflow/pull/60270#discussion_r2673889222


##########
airflow-core/src/airflow/dag_processing/bundles/base.py:
##########
@@ -76,6 +76,34 @@ def get_bundle_version_path(bundle_name: str, version: str) 
-> Path:
     return base_folder / version
 
 
+def get_bundle_permissions() -> tuple[int, int]:
+    """
+    Return configured permissions for bundle directories and files.
+
+    When using user impersonation (run_as_user), bundle directories and files
+    should be group-writable so that impersonated users can access them.
+
+    :return: Tuple of (folder_permissions, file_permissions) as integers
+    """
+    folder_perms = int(conf.get("dag_processor", 
"dag_bundle_new_folder_permissions", fallback="0o775"), 8)

Review Comment:
   What if it's an old version of the config file? Then the setting, including 
the default, will be missing altogether.
   The reason I "object" is because when I removed the fallbacks, one of the 
new tests started failing on a 
   ```none
   E   airflow._shared.configuration.exceptions.AirflowConfigException: 
section/key [dag_processor/dag_bundle_new_folder_permissions] not found in 
config
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to