pierrejeambrun commented on code in PR #60316:
URL: https://github.com/apache/airflow/pull/60316#discussion_r2685591653
##########
airflow-core/src/airflow/ui/src/components/DagActions/DeleteDagButton.tsx:
##########
@@ -44,7 +44,7 @@ const DeleteDagButton = ({ dagDisplayName, dagId, width,
withText = true }: Dele
onSuccessConfirm: () => {
onClose();
if (isOnDagDetailPage) {
- navigate("/dags");
+ void Promise.resolve(navigate("/dags"));
Review Comment:
This fixes the eslint errors because of the mixed returned type of
react-router-dom (it returns a union and we need to handle that union even
though or usage will no return the promise...)
https://github.com/remix-run/react-router/issues/12348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
