[
https://issues.apache.org/jira/browse/AIRFLOW-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987570#comment-16987570
]
ASF GitHub Bot commented on AIRFLOW-6169:
-----------------------------------------
XD-DENG commented on pull request #6724: [AIRFLOW-6169] Avoid unnecessary
int-to-float conversion
URL: https://github.com/apache/airflow/pull/6724
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6169
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
The `x * 1.0` statements in `utils.dates.scale_time_units` were to convert
int to float so that the division operations can work as expected. But since
we're migrating to Py3, this is no longer an issue, and we don't need to do the
explicit type conversion anymore
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Existing tests suffice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Avoid unnecessary int-to-float conversion in utils.dates.scale_time_units
> -------------------------------------------------------------------------
>
> Key: AIRFLOW-6169
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6169
> Project: Apache Airflow
> Issue Type: Improvement
> Components: utils
> Affects Versions: 1.10.6
> Reporter: Xiaodong Deng
> Assignee: Xiaodong Deng
> Priority: Trivial
> Fix For: 2.0.0
>
>
> The "x * 0.1" is doing int-to-float type conversion, which is not necessary
> anymore in Py3 context.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
