OscarLigthart opened a new pull request, #60601: URL: https://github.com/apache/airflow/pull/60601
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> ## Context After upgrading to 3.1.6, we started seeing the following error in our GKEStartPodOperator execution, running in `deferred` mode: ``` AttributeError: 'GKEKubernetesAsyncHook' object has no attribute '_event_polling_fallback' File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/cncf/kubernetes/triggers/pod.py", line 161 in run File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/cncf/kubernetes/triggers/pod.py", line 262 in _wait_for_pod_start File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/cncf/kubernetes/utils/pod_manager.py", line 1018 in watch_pod_events File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/cncf/kubernetes/hooks/kubernetes.py", line 1001 in watch_pod_events ``` * closes: #60600 ## Problem After some research it looks like it's a result of the addition of the `_event_polling_fallback` in the [AsyncKubernetesHook](https://github.com/apache/airflow/blob/main/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py#L818). This is never initialized in the `GKEKubernetesAsyncHook`, because the `AsyncKubernetesHook` init method is never called, due to disruption of the MRO chain. With the current initialization of `GKEKubernetesAsyncHook`, the MRO is: 1. `GKEKubernetesAsyncHook` 2. `GoogleBaseAsyncHook` -> Doesn't call `super().__init__()`, so it stops here 3. `AsyncKubernetesHook` 4. `KubernetesHook` 5. `BaseHook` As stated, the initialization stops after 2 due to a missing `super().__init__()`. Hence, the `_event_polling_fallback` method is never added. ## Solution I figured it would be less invasive to explicitly call both init methods. We could also consider adding the `super().__init__()` call to `GoogleBaseAsyncHook`. This area is relatively new to me, so I'm very open to discuss this! Though the latter feels more invasive, it also feels like a more proper solution. --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) Generated-by: Claude Sonnet 4.5 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
