OscarLigthart commented on PR #60601:
URL: https://github.com/apache/airflow/pull/60601#issuecomment-3760301503
> Hello @OscarLigthart, thank you for your PR! In my opinion the best
solution here is adding `super().__init__()` in the `__init__` method to the
`GoogleBaseAsyncHook`. Like this:
>
> ```
> def __init__(self, **kwargs: Any) -> None:
> self.log.info("GoogleBaseAsyncHook init")
> # add default value to gcp_conn_id
> if "gcp_conn_id" not in kwargs:
> kwargs["gcp_conn_id"] = "google_cloud_default"
>
> self._hook_kwargs = kwargs
> self._sync_hook = None
> super().__init__()
> ```
>
> I have checked this solution in my local Breeze environment by running
`example_kubernetes_engine_async.py` system test and it solved the problem and
started to correctly resolve MRO. @OscarLigthart WDYT about my solution?
Yeah I think that's a much cleaner solution. I reverted my change that was
exactly like this, but passing on the `kwargs`, leading to issues. I will make
this change 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
