eladkal commented on code in PR #60369:
URL: https://github.com/apache/airflow/pull/60369#discussion_r2699137186
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/powerbi.py:
##########
@@ -65,6 +65,7 @@ class PowerBIDatasetRefreshOperator(BaseOperator):
:param check_interval: Number of seconds to wait before rechecking the
refresh status.
:param request_body: Additional arguments to pass to the request body, as
described in
https://learn.microsoft.com/en-us/rest/api/power-bi/datasets/refresh-dataset-in-group#request-body.
+ :param wait_for_termination: If True, wait for the dataset refresh to
complete. If False, trigger the refresh and return immediately without waiting.
Review Comment:
I find this a bit confusing(?)
We need to have both `wait_for_termination` and `deferrable` similar to how
we do it with other operators
https://github.com/apache/airflow/blob/fdd12cfde230ca178e14f8ba4a4cbaaba1f0806a/providers/amazon/src/airflow/providers/amazon/aws/operators/emr.py#L91-L97
both are considered as waiting for completion it just that one holds worker
and the other does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
