eladkal commented on code in PR #60369:
URL: https://github.com/apache/airflow/pull/60369#discussion_r2700941402
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/powerbi.py:
##########
@@ -65,6 +65,7 @@ class PowerBIDatasetRefreshOperator(BaseOperator):
:param check_interval: Number of seconds to wait before rechecking the
refresh status.
:param request_body: Additional arguments to pass to the request body, as
described in
https://learn.microsoft.com/en-us/rest/api/power-bi/datasets/refresh-dataset-in-group#request-body.
+ :param wait_for_termination: If True, wait for the dataset refresh to
complete. If False, trigger the refresh and return immediately without waiting.
Review Comment:
Regardless of what is happening under the hood. The operator parameters
should be:
wait_for_termination -> wait in sync
deferrable -> wait async using PowerBITrigger
We should align the operator accordingly.
> Add synchronous wrapper methods to the hook
That should be easy unless i am missing something. You can just do what is
already implemented in any of the aws hooks. The only difference is the API
call to get the updated status. Am I wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
