sjyangkevin commented on code in PR #60727:
URL: https://github.com/apache/airflow/pull/60727#discussion_r2701998515
##########
PR_DESCRIPTION.md:
##########
Review Comment:
This looks like a file generated by the AI tool, we may not need this file
here as it is the description for the PR.
##########
providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:
##########
@@ -331,17 +331,7 @@ def execute(self, context: Context) -> None:
gcp_conn_id=self.gcp_conn_id,
impersonation_chain=self.impersonation_chain,
)
- try:
- hook.delete_instance(project_id=self.project_id,
instance_id=self.instance_id)
- except google.api_core.exceptions.NotFound:
- self.log.info(
- "The instance '%s' does not exist in project '%s'. Consider it
as deleted",
- self.instance_id,
- self.project_id,
- )
- except google.api_core.exceptions.GoogleAPICallError as e:
- self.log.error("An error occurred. Exiting.")
- raise e
+ hook.delete_instance(project_id=self.project_id,
instance_id=self.instance_id)
Review Comment:
another case in the error handling `except
google.api_core.exceptions.GoogleAPICallError as e` is also removed. In this
case, an error need to be raised instead of showing a logging. It looks
different from the PR description that only `NotFound` looks redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
