shahar1 commented on code in PR #60727:
URL: https://github.com/apache/airflow/pull/60727#discussion_r2702757737
##########
providers/google/src/airflow/providers/google/cloud/operators/bigtable.py:
##########
@@ -331,17 +331,7 @@ def execute(self, context: Context) -> None:
gcp_conn_id=self.gcp_conn_id,
impersonation_chain=self.impersonation_chain,
)
- try:
- hook.delete_instance(project_id=self.project_id,
instance_id=self.instance_id)
- except google.api_core.exceptions.NotFound:
- self.log.info(
- "The instance '%s' does not exist in project '%s'. Consider it
as deleted",
- self.instance_id,
- self.project_id,
- )
- except google.api_core.exceptions.GoogleAPICallError as e:
- self.log.error("An error occurred. Exiting.")
- raise e
+ hook.delete_instance(project_id=self.project_id,
instance_id=self.instance_id)
Review Comment:
If such exception occurs, it will occur even without exception case, but
without showing the error log "An error occured. Exiting.".
Whether the latter log error is really necessary - I doubt, but I think that
it should be clarified within the PR description and title.
##########
PR_DESCRIPTION.md:
##########
Review Comment:
+1 to the above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
