amoghrajesh commented on code in PR #60744: URL: https://github.com/apache/airflow/pull/60744#discussion_r2702505757
########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. + +Guidelines from ASF are listed at ASF: +`New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`_ Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ General prerequisites that we look for in all candidates: -1. Consistent contribution over last few months +1. Consistent contribution over at least three months 2. Visibility on discussions on the dev mailing list, Slack channels or GitHub issues/discussions -3. Contributions to community health and project's sustainability for the long-term -4. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ + including casting non-binding votes and testing RCs Review Comment: ```suggestion including casting non-binding votes and testing release candidates for various Airflow releases. ``` ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. Review Comment: ```suggestion have no chance to spot and promote such candidates. ``` ########## COMMITTERS.rst: ########## @@ -91,17 +101,24 @@ Code contribution - Docker Image - Helm Chart - Dev Tools (Breeze / CI) - - Certain Providers + - Providers - especially those where PMC is a steward 5. Has made a significant improvement or added an integration with services/technologies important to the Airflow Ecosystem - -6. Actively participated in the security process, as a member of security team, discussing, assessing and +6. Actively participated in the security process, as a member of the security team, discussing, assessing and Review Comment: This alone is in the past. Maybe have it in same _tense_ as others ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. + +Guidelines from ASF are listed at ASF: +`New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`_ Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ General prerequisites that we look for in all candidates: -1. Consistent contribution over last few months +1. Consistent contribution over at least three months 2. Visibility on discussions on the dev mailing list, Slack channels or GitHub issues/discussions -3. Contributions to community health and project's sustainability for the long-term -4. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ + including casting non-binding votes and testing RCs +3. Helping other contributors and users - with sharing their code contributor's experience and reviewing other's code +4. Contributions to community health and project's sustainability for the long-term +5. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ Code contribution -^^^^^^^^^^^^^^^^^^ +^^^^^^^^^^^^^^^^^ + +A prospective committer typically demonstrates several of the following: Review Comment: IDK, sounds clearer? ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. + +Guidelines from ASF are listed at ASF: +`New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`_ Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ General prerequisites that we look for in all candidates: -1. Consistent contribution over last few months +1. Consistent contribution over at least three months 2. Visibility on discussions on the dev mailing list, Slack channels or GitHub issues/discussions -3. Contributions to community health and project's sustainability for the long-term -4. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ + including casting non-binding votes and testing RCs +3. Helping other contributors and users - with sharing their code contributor's experience and reviewing other's code +4. Contributions to community health and project's sustainability for the long-term +5. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ Code contribution -^^^^^^^^^^^^^^^^^^ +^^^^^^^^^^^^^^^^^ + +A prospective committer typically demonstrates several of the following: Review Comment: ```suggestion A potential candidate for committership typically demonstrates several of the following: ``` ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. + +Guidelines from ASF are listed at ASF: +`New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`_ Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ General prerequisites that we look for in all candidates: -1. Consistent contribution over last few months +1. Consistent contribution over at least three months 2. Visibility on discussions on the dev mailing list, Slack channels or GitHub issues/discussions -3. Contributions to community health and project's sustainability for the long-term -4. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ + including casting non-binding votes and testing RCs +3. Helping other contributors and users - with sharing their code contributor's experience and reviewing other's code Review Comment: This one isn't too clear to me. What are we intending to convey in: `with sharing their code contributor's experience`? ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they Review Comment: ```suggestion a committer (and eventually a PMC member) without ever having to change a single line of code, but that requires visibility and presence in the regular community channels - slack, devlist, social media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they ``` ########## COMMITTERS.rst: ########## @@ -91,17 +101,24 @@ Code contribution - Docker Image - Helm Chart - Dev Tools (Breeze / CI) - - Certain Providers + - Providers - especially those where PMC is a steward 5. Has made a significant improvement or added an integration with services/technologies important to the Airflow Ecosystem - -6. Actively participated in the security process, as a member of security team, discussing, assessing and +6. Actively participated in the security process, as a member of the security team, discussing, assessing and fixing security issues. +7. Demonstrates skills to maintain the complex codebase to ensure keeping maturity of product and complexity Review Comment: Like CI? ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. + +Guidelines from ASF are listed at ASF: +`New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`_ Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ General prerequisites that we look for in all candidates: -1. Consistent contribution over last few months +1. Consistent contribution over at least three months 2. Visibility on discussions on the dev mailing list, Slack channels or GitHub issues/discussions -3. Contributions to community health and project's sustainability for the long-term -4. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ + including casting non-binding votes and testing RCs +3. Helping other contributors and users - with sharing their code contributor's experience and reviewing other's code +4. Contributions to community health and project's sustainability for the long-term Review Comment: ```suggestion 4. Contributions to community health and project's sustainability in the long-term ``` ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. + +Guidelines from ASF are listed at ASF: +`New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`_ Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ General prerequisites that we look for in all candidates: -1. Consistent contribution over last few months +1. Consistent contribution over at least three months 2. Visibility on discussions on the dev mailing list, Slack channels or GitHub issues/discussions -3. Contributions to community health and project's sustainability for the long-term -4. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ + including casting non-binding votes and testing RCs +3. Helping other contributors and users - with sharing their code contributor's experience and reviewing other's code +4. Contributions to community health and project's sustainability for the long-term +5. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ Code contribution -^^^^^^^^^^^^^^^^^^ +^^^^^^^^^^^^^^^^^ + +A prospective committer typically demonstrates several of the following: -1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including +1. Makes high-quality commits (including meaningful commit messages), and assess the impact of the changes, including upgrade paths or deprecation policies -2. Testing Release Candidates to help the release cycle -3. Proposed and led to completion Airflow Improvement Proposal(s) -4. Demonstrates an understanding of one of the following areas or has displayed a holistic understanding +2. Tests Release Candidates to help the release cycle +3. Proposes and leads Airflow Improvement Proposal(s) to completion Review Comment: ```suggestion 3. Proposes and/or leads Airflow Improvement Proposal(s) to completion ``` ########## COMMITTERS.rst: ########## @@ -127,39 +146,52 @@ This means that committers should: the case if no one from the community is taking it on. * Improve processes and tooling * Refactoring code +* Taking part in handling regular chores - i.e. maintenance of Airflow - for example making sure that + our canary builds are green, upgrading dependencies regularly, monitoring for security alerts. + Ideally also automating those as much as possible. Guidelines for promoting Committers to Airflow PMC ---------------------------------------------------- +-------------------------------------------------- To become a PMC member the committers should meet all **general prerequisites**. -Apart from that the person should demonstrate distinct **community involvement** or **code contributions**. +Apart from that the person should demonstrate distinct and sustained **community involvement** or +**code contributions**. -Guidelines from ASF are listed at -`ASF: New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`__. Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ * Has been a committer for at least 3 months -* Is still active community member (Visible on mailing list or reviewing PRs at the minimum) +* Is currently an active community member + (Visible in mailing list, other channel discussions or reviewing PRs at the minimum) Review Comment: This seems repetitive, we mention it below in "community involvement" ########## COMMITTERS.rst: ########## @@ -127,39 +146,52 @@ This means that committers should: the case if no one from the community is taking it on. * Improve processes and tooling * Refactoring code +* Taking part in handling regular chores - i.e. maintenance of Airflow - for example making sure that + our canary builds are green, upgrading dependencies regularly, monitoring for security alerts. + Ideally also automating those as much as possible. Guidelines for promoting Committers to Airflow PMC ---------------------------------------------------- +-------------------------------------------------- To become a PMC member the committers should meet all **general prerequisites**. -Apart from that the person should demonstrate distinct **community involvement** or **code contributions**. +Apart from that the person should demonstrate distinct and sustained **community involvement** or +**code contributions**. -Guidelines from ASF are listed at -`ASF: New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`__. Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ * Has been a committer for at least 3 months -* Is still active community member (Visible on mailing list or reviewing PRs at the minimum) +* Is currently an active community member + (Visible in mailing list, other channel discussions or reviewing PRs at the minimum) + Community involvement -^^^^^^^^^^^^^^^^^^^^^^ +^^^^^^^^^^^^^^^^^^^^^ * Visibility on discussions on the dev mailing list * Spreading the word for "Airflow" either: * Talks at meetups, conferences, etc * Creating content like videos, blogs, etc + * Actively participates in public discussions about Airflow happening in social media or Github, + promoting Airflow as a product * Growing the community: * Mentors new members/contributors * Answers users/contributors via GitHub issues, dev list or slack +* Is aware and pays attention to Airflow public image Review Comment: ```suggestion * Is aware and pays attention to public image of Airflow ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
