Lee-W commented on code in PR #60744: URL: https://github.com/apache/airflow/pull/60744#discussion_r2702441745
########## COMMITTERS.rst: ########## @@ -207,32 +237,54 @@ become active again you can simply email the PMC and ask to be reinstated. The PMC also can mark committers as inactive after they have not been involved in the community for more than 12 months. + New Committer Onboarding Steps ------------------------------ To be able to merge PRs, committers have to integrate their GitHub ID with Apache systems. To do that follow steps: -1. Verify you have a GitHub ID `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. -2. Merge your Apache and GitHub accounts using `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your +1. Verify you have a GitHub ID + `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. +2. Merge your Apache and GitHub accounts using + `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your GitHub ID to your Apache account. You should see 5 green checks in GitBox. 3. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation. -4. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. +4. After accepting the GitHub Invitation verify that you are a member of the + `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. Additionally, as a committer you can view the team membership at: * https://github.com/orgs/apache/teams/airflow-committers/members * https://whimsy.apache.org/roster/committee/airflow -5. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ +5. Ask in ``#internal-airflow-ci-cd`` channel to be + `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI team. Wait for confirmation that this is done and some helpful tips from the CI team (Temporarily disabled) 6. After confirming that step 5 is done, open a PR to include your GitHub ID in: * ``dev/breeze/src/airflow_breeze/global_constants.py`` (COMMITTERS variable) * name and GitHub ID in `project.rst <https://github.com/apache/airflow/blob/main/airflow-core/docs/project.rst>`__. * If you had been a collaborator role before getting committer, remove your GitHub ID from ``.asf.yaml``. + 7. Raise a PR to `airflow-site <https://github.com/apache/airflow-site>`_ repository with the following additions: + (A kind request: If there are other committers who joined around the same time, please create a unified PR for + all of you together.) + + * List your name(s) in the + `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. + * Post an entry in + `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. + +8. Ask a release manager to make Slack announcement + - * List your name(s) in the `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. - * Post an entry in `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. +New PMC Onboarding steps +------------------------ - **A kind request**: If there are other committers who joined around the same time, please create a unified PR for all of you together. +1. Familiarise yourself with https://community.apache.org/pmc/responsibilities.html Review Comment: ```suggestion 1. Familiarise yourself with `<PMC Responsibilities>https://community.apache.org/pmc/responsibilities.html`_ ``` ########## COMMITTERS.rst: ########## @@ -55,33 +55,43 @@ repositories, i.e., they can modify the code, documentation, and website by them accept other contributions. There is no strict protocol for becoming a committer. Candidates for new committers are typically people that are active contributors and community members. -Some people might be active in several of those areas and while they might have not enough 'achievements' in any +Some people might be active in several of those areas and while they might not have enough 'achievements' in any single one of those, their combined contributions in several areas all count. As a community, we appreciate contributions to the Airflow codebase, but we also place equal value on those who help Airflow by improving the community in some way. It is entirely possible to become -a committer (and eventually a PMC member) without ever having to change a single line of code. +a committer (and eventually a PMC member) without ever having to change a single line of code, +though that requires visibility and presence in the regular community channels - slack, devlist, social +media - this is important for the PMC to be aware of such activities. If PMC is not aware of those, they +have no chance to spot and discuss such candidates. + +Guidelines from ASF are listed at ASF: +`New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`_ Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ General prerequisites that we look for in all candidates: -1. Consistent contribution over last few months +1. Consistent contribution over at least three months 2. Visibility on discussions on the dev mailing list, Slack channels or GitHub issues/discussions -3. Contributions to community health and project's sustainability for the long-term -4. Understands contributor/committer guidelines: `Contributors' Guide <contributing-docs/README.rst>`__ + including casting non-binding votes and testing RCs Review Comment: ```suggestion including casting non-binding votes and testing release candidates. ``` ########## COMMITTERS.rst: ########## @@ -127,39 +146,52 @@ This means that committers should: the case if no one from the community is taking it on. * Improve processes and tooling * Refactoring code +* Taking part in handling regular chores - i.e. maintenance of Airflow - for example making sure that + our canary builds are green, upgrading dependencies regularly, monitoring for security alerts. + Ideally also automating those as much as possible. Guidelines for promoting Committers to Airflow PMC ---------------------------------------------------- +-------------------------------------------------- To become a PMC member the committers should meet all **general prerequisites**. -Apart from that the person should demonstrate distinct **community involvement** or **code contributions**. +Apart from that the person should demonstrate distinct and sustained **community involvement** or +**code contributions**. -Guidelines from ASF are listed at -`ASF: New Candidates for Committership <http://community.apache.org/newcommitter.html#guidelines-for-assessing-new-candidates-for-committership>`__. Prerequisites -^^^^^^^^^^^^^^ +^^^^^^^^^^^^^ * Has been a committer for at least 3 months -* Is still active community member (Visible on mailing list or reviewing PRs at the minimum) +* Is currently an active community member + (Visible in mailing list, other channel discussions or reviewing PRs at the minimum) + Community involvement -^^^^^^^^^^^^^^^^^^^^^^ +^^^^^^^^^^^^^^^^^^^^^ * Visibility on discussions on the dev mailing list * Spreading the word for "Airflow" either: * Talks at meetups, conferences, etc * Creating content like videos, blogs, etc + * Actively participates in public discussions about Airflow happening in social media or Github, Review Comment: ```suggestion * Actively participates in public discussions about Airflow happening in social media or GitHub, ``` ########## COMMITTERS.rst: ########## @@ -207,32 +237,54 @@ become active again you can simply email the PMC and ask to be reinstated. The PMC also can mark committers as inactive after they have not been involved in the community for more than 12 months. + New Committer Onboarding Steps ------------------------------ To be able to merge PRs, committers have to integrate their GitHub ID with Apache systems. To do that follow steps: -1. Verify you have a GitHub ID `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. -2. Merge your Apache and GitHub accounts using `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your +1. Verify you have a GitHub ID + `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. +2. Merge your Apache and GitHub accounts using + `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your GitHub ID to your Apache account. You should see 5 green checks in GitBox. 3. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation. -4. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. +4. After accepting the GitHub Invitation verify that you are a member of the + `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. Additionally, as a committer you can view the team membership at: * https://github.com/orgs/apache/teams/airflow-committers/members * https://whimsy.apache.org/roster/committee/airflow -5. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ +5. Ask in ``#internal-airflow-ci-cd`` channel to be + `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI team. Wait for confirmation that this is done and some helpful tips from the CI team (Temporarily disabled) 6. After confirming that step 5 is done, open a PR to include your GitHub ID in: * ``dev/breeze/src/airflow_breeze/global_constants.py`` (COMMITTERS variable) * name and GitHub ID in `project.rst <https://github.com/apache/airflow/blob/main/airflow-core/docs/project.rst>`__. * If you had been a collaborator role before getting committer, remove your GitHub ID from ``.asf.yaml``. + 7. Raise a PR to `airflow-site <https://github.com/apache/airflow-site>`_ repository with the following additions: + (A kind request: If there are other committers who joined around the same time, please create a unified PR for + all of you together.) + + * List your name(s) in the + `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. + * Post an entry in + `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. + +8. Ask a release manager to make Slack announcement + - * List your name(s) in the `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. - * Post an entry in `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. +New PMC Onboarding steps Review Comment: ```suggestion New PMC Member Onboarding steps ``` ########## COMMITTERS.rst: ########## @@ -207,32 +237,54 @@ become active again you can simply email the PMC and ask to be reinstated. The PMC also can mark committers as inactive after they have not been involved in the community for more than 12 months. + New Committer Onboarding Steps ------------------------------ To be able to merge PRs, committers have to integrate their GitHub ID with Apache systems. To do that follow steps: -1. Verify you have a GitHub ID `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. -2. Merge your Apache and GitHub accounts using `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your +1. Verify you have a GitHub ID + `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. +2. Merge your Apache and GitHub accounts using + `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your GitHub ID to your Apache account. You should see 5 green checks in GitBox. 3. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation. -4. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. +4. After accepting the GitHub Invitation verify that you are a member of the + `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. Additionally, as a committer you can view the team membership at: * https://github.com/orgs/apache/teams/airflow-committers/members * https://whimsy.apache.org/roster/committee/airflow -5. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ +5. Ask in ``#internal-airflow-ci-cd`` channel to be + `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI team. Wait for confirmation that this is done and some helpful tips from the CI team (Temporarily disabled) 6. After confirming that step 5 is done, open a PR to include your GitHub ID in: * ``dev/breeze/src/airflow_breeze/global_constants.py`` (COMMITTERS variable) * name and GitHub ID in `project.rst <https://github.com/apache/airflow/blob/main/airflow-core/docs/project.rst>`__. * If you had been a collaborator role before getting committer, remove your GitHub ID from ``.asf.yaml``. + 7. Raise a PR to `airflow-site <https://github.com/apache/airflow-site>`_ repository with the following additions: + (A kind request: If there are other committers who joined around the same time, please create a unified PR for + all of you together.) + + * List your name(s) in the + `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. + * Post an entry in + `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. + +8. Ask a release manager to make Slack announcement + - * List your name(s) in the `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. - * Post an entry in `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. +New PMC Onboarding steps +------------------------ - **A kind request**: If there are other committers who joined around the same time, please create a unified PR for all of you together. +1. Familiarise yourself with https://community.apache.org/pmc/responsibilities.html +2. Subscribe to the private mailing list: [email protected]. Do this by sending an empty email to + [email protected] and following the instructions in the automated response you'll receive. Review Comment: ```suggestion ``[email protected]`` and following the instructions in the automated response you'll receive. ``` ########## COMMITTERS.rst: ########## @@ -91,17 +101,24 @@ Code contribution - Docker Image - Helm Chart - Dev Tools (Breeze / CI) - - Certain Providers + - Providers - especially those where PMC is a steward 5. Has made a significant improvement or added an integration with services/technologies important to the Airflow Ecosystem - -6. Actively participated in the security process, as a member of security team, discussing, assessing and +6. Actively participated in the security process, as a member of the security team, discussing, assessing and fixing security issues. +7. Demonstrates skills to maintain the complex codebase to ensure keeping maturity of product and complexity +8. Has been actively helping other contributors and users - in Slack, GitHub issues, GitHub discussions - by + guiding their coding practices, reviewing their code and answering code-related questions + +Note: As mentioned earlier, there may be exceptions for code contributions requirements for contributors who +provide sustained, high-impact non-code contributions (for example, community leadership, outlining AIPs, etc.). +Such exceptions are rare and chosen selectively, so contributors with coding skills who aim to become committers +and PMC are generally encouraged to follow the regular path. Review Comment: ```suggestion and PMC members are generally encouraged to follow the regular path. ``` ########## COMMITTERS.rst: ########## @@ -207,32 +237,54 @@ become active again you can simply email the PMC and ask to be reinstated. The PMC also can mark committers as inactive after they have not been involved in the community for more than 12 months. + New Committer Onboarding Steps ------------------------------ To be able to merge PRs, committers have to integrate their GitHub ID with Apache systems. To do that follow steps: -1. Verify you have a GitHub ID `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. -2. Merge your Apache and GitHub accounts using `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your +1. Verify you have a GitHub ID + `enabled with 2FA <https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/>`__. +2. Merge your Apache and GitHub accounts using + `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your GitHub ID to your Apache account. You should see 5 green checks in GitBox. 3. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation. -4. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. +4. After accepting the GitHub Invitation verify that you are a member of the + `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. Additionally, as a committer you can view the team membership at: * https://github.com/orgs/apache/teams/airflow-committers/members * https://whimsy.apache.org/roster/committee/airflow -5. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ +5. Ask in ``#internal-airflow-ci-cd`` channel to be + `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI team. Wait for confirmation that this is done and some helpful tips from the CI team (Temporarily disabled) 6. After confirming that step 5 is done, open a PR to include your GitHub ID in: * ``dev/breeze/src/airflow_breeze/global_constants.py`` (COMMITTERS variable) * name and GitHub ID in `project.rst <https://github.com/apache/airflow/blob/main/airflow-core/docs/project.rst>`__. * If you had been a collaborator role before getting committer, remove your GitHub ID from ``.asf.yaml``. + 7. Raise a PR to `airflow-site <https://github.com/apache/airflow-site>`_ repository with the following additions: + (A kind request: If there are other committers who joined around the same time, please create a unified PR for + all of you together.) + + * List your name(s) in the + `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. + * Post an entry in + `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. + +8. Ask a release manager to make Slack announcement + - * List your name(s) in the `committers list <https://github.com/apache/airflow-site/blob/main/landing-pages/site/data/committers.json>`__. - * Post an entry in `Announcements <https://github.com/apache/airflow-site/blob/main/landing-pages/site/content/en/announcements/_index.md>`__. +New PMC Onboarding steps +------------------------ - **A kind request**: If there are other committers who joined around the same time, please create a unified PR for all of you together. +1. Familiarise yourself with https://community.apache.org/pmc/responsibilities.html +2. Subscribe to the private mailing list: [email protected]. Do this by sending an empty email to Review Comment: ```suggestion 2. Subscribe to the private mailing list: ``[email protected]``. Do this by sending an empty email to ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
