Fury0508 commented on PR #60193:
URL: https://github.com/apache/airflow/pull/60193#issuecomment-3767534823

   @bugraoz93 I've made the following updates:
   
   **Changes in this commit:**
   
   1. **cli_config.py** - Required (non-nullable) parameters are now positional 
arguments (no `--` prefix), while optional parameters remain as flags with `--`
   
   2. **test_cli_config.py** - Updated the test to skip `dest` check for 
positional arguments, since argparse automatically infers `dest` for positional 
args and doesn't allow setting it explicitly
   
   **Before:**
   ```bash
   airflowctl connections create --connection-id="test" --conn-type="postgres"
   ```
   
   **After:**
   ```bash
   airflowctl connections create test postgres
   ```
   
   The test was failing because it expected all args to have `dest` in kwargs, 
but positional args don't have explicit `dest` (argparse handles it 
automatically).
   
   Could you please re-review when you get a chance? Also, if you could approve 
the workflow so CI can run, that would be helpful. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to