VedantMadane commented on code in PR #60591: URL: https://github.com/apache/airflow/pull/60591#discussion_r2714102408
########## airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearAllMappedTaskInstancesDialog.tsx: ########## @@ -0,0 +1,200 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Button, Flex, Heading, useDisclosure, VStack } from "@chakra-ui/react"; +import { useState } from "react"; +import { useTranslation } from "react-i18next"; +import { CgRedo } from "react-icons/cg"; + +import type { TaskInstanceResponse } from "openapi/requests/types.gen"; +import { ActionAccordion } from "src/components/ActionAccordion"; +import { Checkbox, Dialog } from "src/components/ui"; +import SegmentedControl from "src/components/ui/SegmentedControl"; +import { useClearTaskInstances } from "src/queries/useClearTaskInstances"; +import { useClearTaskInstancesDryRun } from "src/queries/useClearTaskInstancesDryRun"; +import { isStatePending, useAutoRefresh } from "src/utils"; + +import ClearTaskInstanceConfirmationDialog from "./ClearTaskInstanceConfirmationDialog"; + +type Props = { + readonly dagId: string; + readonly dagRunId: string; + readonly onClose: () => void; + readonly open: boolean; + readonly taskId: string; +}; + +const ClearAllMappedTaskInstancesDialog = ({ + dagId, + dagRunId, + onClose: onCloseDialog, Review Comment: The `onClose` prop (renamed as `onCloseDialog`) is actually being used in three places, following the same pattern as `ClearTaskInstanceDialog.tsx`: 1. **Line 56**: `onSuccessConfirm: onCloseDialog` - passed to `useClearTaskInstances` hook 2. **Line 104**: `onOpenChange={onCloseDialog}` - passed to `Dialog.Root` to handle dialog state changes 3. **Line 196**: `onCloseDialog();` - called directly in the confirmation callback The implementation matches exactly how `ClearTaskInstanceDialog.tsx` handles the `onClose` prop. Is there a specific issue with how it's being used, or did you mean something else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
