VedantMadane commented on code in PR #60591: URL: https://github.com/apache/airflow/pull/60591#discussion_r2714126647
########## airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearAllMappedTaskInstancesButton.tsx: ########## @@ -0,0 +1,64 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Box, useDisclosure } from "@chakra-ui/react"; +import { useTranslation } from "react-i18next"; +import { CgRedo } from "react-icons/cg"; + +import { Tooltip } from "src/components/ui"; +import ActionButton from "src/components/ui/ActionButton"; + +import ClearAllMappedTaskInstancesDialog from "./ClearAllMappedTaskInstancesDialog"; + +type Props = { + readonly dagId: string; + readonly dagRunId: string; + readonly taskId: string; + readonly withText?: boolean; +}; + +const ClearAllMappedTaskInstancesButton = ({ dagId, dagRunId, taskId, withText = true }: Props) => { + const { onClose, onOpen, open } = useDisclosure(); + const { t: translate } = useTranslation(); + + return ( + <Tooltip closeDelay={100} content={translate("dags:runAndTaskActions.clearAllMapped.buttonTooltip")} openDelay={100}> Review Comment: I've added the shift+C hotkey shortcut as requested. Here are the changes: **Changes to ClearAllMappedTaskInstancesButton.tsx:** 1. Added import for useHotkeys: ```typescript import { useHotkeys } from "react-hotkeys-hook"; ``` 2. Added isHotkeyEnabled prop to Props type: ```typescript readonly isHotkeyEnabled?: boolean; ``` 3. Updated function parameters: ```typescript const ClearAllMappedTaskInstancesButton = ({ dagId, dagRunId, isHotkeyEnabled = false, taskId, withText = true }: Props) => { ``` 4. Implemented the hotkey hook (add after translate declaration, before return): ```typescript useHotkeys( "shift+c", () => { onOpen(); }, { enabled: isHotkeyEnabled }, ); ``` This follows the same pattern as ClearTaskInstanceButton.tsx. The hotkey will only be active when isHotkeyEnabled prop is set to true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
