kaxil commented on code in PR #60776:
URL: https://github.com/apache/airflow/pull/60776#discussion_r2716976751
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -89,8 +88,17 @@ def get_link(self, operator: BaseOperator, *, ti_key:
TaskInstanceKey) -> str:
trigger_dag_id = operator.trigger_dag_id
if not AIRFLOW_V_3_0_PLUS:
from airflow.models.renderedtifields import
RenderedTaskInstanceFields
+ from airflow.models.taskinstancekey import TaskInstanceKey as
CoreTaskInstanceKey
+
+ core_ti_key = CoreTaskInstanceKey(
+ dag_id=ti_key.dag_id,
+ task_id=ti_key.task_id,
+ run_id=ti_key.run_id,
+ try_number=ti_key.try_number,
+ map_index=ti_key.map_index,
+ )
Review Comment:
Why do we need to do this, isn't technically those are same attribs?
##########
task-sdk/src/airflow/sdk/bases/operatorlink.py:
##########
@@ -23,8 +23,8 @@
import attrs
if TYPE_CHECKING:
- from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.sdk import BaseOperator
+ from airflow.sdk.types import TaskInstanceKey
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
