amoghrajesh commented on code in PR #60776:
URL: https://github.com/apache/airflow/pull/60776#discussion_r2719617821
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kubernetes_helper_functions.py:
##########
@@ -166,7 +166,8 @@ def annotations_to_key(annotations: dict[str, str]) ->
TaskInstanceKey:
# Compat: Look up the run_id from the TI table!
from airflow.models.dagrun import DagRun
- from airflow.models.taskinstance import TaskInstance, TaskInstanceKey
+ from airflow.models.taskinstance import TaskInstance
+ from airflow.models.taskinstancekey import TaskInstanceKey
Review Comment:
I wanted to change this to common.compat too but unfortunately it is
eventually going to go through the KE. Since baseexecutor is typed with `from
airflow.models.taskinstancekey import TaskInstanceKey`, we won't be able to use
`airflow.sdk.types.TaskInstanceKey ` for typing for _any_ executor related
functions which somewhat makes sense too because executor is not supposed to
consume from sdk i think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
