SameerMesiah97 commented on code in PR #61013:
URL: https://github.com/apache/airflow/pull/61013#discussion_r2724670822
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -220,11 +220,16 @@ def _default_conn_name_from(mod_path, hook_name):
"azure_remote_logging", "remote_wasb_log_container",
fallback="airflow-logs"
)
+ if remote_base_log_folder.startswith("wasb://"):
+ wasb_remote_base = remote_base_log_folder.removeprefix("wasb://")
+ else:
+ wasb_remote_base = remote_base_log_folder
+
Review Comment:
The normalisation logic is solid but it would not hurt to add a comment
explaining why you are stripping the prefix. This normalization isn’t obvious
without context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
