vatsrahul1001 commented on code in PR #59939: URL: https://github.com/apache/airflow/pull/59939#discussion_r2727308724
########## airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts: ########## @@ -0,0 +1,41 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { test } from "@playwright/test"; +import { AssetsPage } from "tests/e2e/pages/AssetsPage"; + +test.describe("Assets Page", () => { + let assetsPage: AssetsPage; + const assetName = "s3://dag1/output_1.txt"; Review Comment: Can we get this from config ########## airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts: ########## @@ -0,0 +1,73 @@ +/*! Review Comment: Add the test to the existing asset.spec.ts ########## airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts: ########## @@ -0,0 +1,73 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { expect, test } from "@playwright/test"; +import { AUTH_FILE } from "playwright.config"; + +import { AssetDetailPage } from "../pages/AssetDetailPage"; +import { DagsPage } from "../pages/DagsPage"; + +test.describe("Asset Details Page", () => { + let assetDetailPage: AssetDetailPage; + const assetName = "s3://dag1/output_1.txt"; + + test.beforeAll(async ({ browser }) => { Review Comment: asset.spec.ts already have beforeALL if you add this test to same test spec we can use same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
