junaiddshaukat commented on PR #59939: URL: https://github.com/apache/airflow/pull/59939#issuecomment-3800504644
Hi @vatsrahul1001, thanks for the feedback! I've made the requested changes: 1. **Merged test into existing `asset.spec.ts`** - Added the asset detail test to the existing spec file instead of a separate file 2. **Reusing existing `beforeAll`** - The test now uses the existing `beforeAll` setup that triggers `asset_produces_1` 3. **Using config for asset name** - Added `testConfig.asset.name` in `playwright.config.ts` and updated both the search test and detail test to use it 4. **Removed `assets.spec.ts`** - Deleted the duplicate spec file The `AssetDetailPage.ts` page object is still used for the detail page verification methods. Ready for re-review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
