chen0427ok commented on code in PR #59374:
URL: https://github.com/apache/airflow/pull/59374#discussion_r2730183449
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -331,8 +606,36 @@ export class DagsPage extends BasePage {
* Wait for DAG list to be rendered
*/
private async waitForDagList(): Promise<void> {
- await
expect(this.page.locator('[data-testid="dag-id"]').first()).toBeVisible({
- timeout: 10_000,
- });
+ // Wait for either card-list, table-list, or empty state to be visible
+ const cardList = this.page.locator('[data-testid="card-list"]');
+ const tableList = this.page.locator('[data-testid="table-list"]');
+ const noDagFound = this.page.locator("text=No Dag found");
Review Comment:
<img width="1280" height="720" alt="test-failed-1"
src="https://github.com/user-attachments/assets/027ba590-3997-4604-9bf1-9985fe29f1fb";
/>
"I checked my local environment and the UI actually renders "No Dag found"
(singular), as shown in the screenshot.
I tried changing the locator to "No Dags found" as suggested, but that
caused the tests to fail/timeout. Reverting it to the singular form fixed the
issue and all tests passed locally."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
