o-nikolas commented on code in PR #61153:
URL: https://github.com/apache/airflow/pull/61153#discussion_r2734244930
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -402,9 +440,20 @@ def trigger_tasks(self, open_slots: int) -> None:
carrier = Trace.inject()
ti.context_carrier = carrier
- workload_list.append(item)
+ workload_list.append(workload)
+
if workload_list:
- self._process_workloads(workload_list)
+ try:
+ self._process_workloads(workload_list)
+ except AttributeError as e:
+ if any(isinstance(workload, workloads.ExecuteCallback) for
workload in workload_list):
Review Comment:
If we know exactly how to check for the unsupported use case, why don't we
just check before trying to call `__process_workloads()`? Also, we can check
much earlier in the queueing of workloads because we can check the
`supports_callback` attr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
