ferruzzi commented on code in PR #61153:
URL: https://github.com/apache/airflow/pull/61153#discussion_r2738531022
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -402,9 +440,20 @@ def trigger_tasks(self, open_slots: int) -> None:
carrier = Trace.inject()
ti.context_carrier = carrier
- workload_list.append(item)
+ workload_list.append(workload)
+
if workload_list:
- self._process_workloads(workload_list)
+ try:
+ self._process_workloads(workload_list)
+ except AttributeError as e:
+ if any(isinstance(workload, workloads.ExecuteCallback) for
workload in workload_list):
Review Comment:
Fair, I can make the change. I was trying to remove some nesting and using
the try/except block as flow-control felt pythonic, but if it's less clear then
I can change it up and add a "fail fast" escape hatch in the next revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
