jscheffl commented on code in PR #61153:
URL: https://github.com/apache/airflow/pull/61153#discussion_r2743533937
##########
providers/celery/src/airflow/providers/celery/executors/celery_executor.py:
##########
@@ -139,17 +140,31 @@ def _process_tasks(self, task_tuples:
Sequence[TaskTuple]) -> None:
def _process_workloads(self, workloads: Sequence[workloads.All]) -> None:
# Airflow V3 version -- have to delay imports until we know we are on
v3
- from airflow.executors.workloads import ExecuteTask
+ from airflow.executors.workloads import ExecuteCallback, ExecuteTask
Review Comment:
The `ExecuteCallback` was added leter than 3.0.0, so if you import here it
will break in core versions <3.2.0?
Can you either make a (very) late or lazy import such that no upgrade
dependency to airflow core is generated and that it is still working with 3.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
