xBis7 commented on code in PR #56150: URL: https://github.com/apache/airflow/pull/56150#discussion_r2771035008
########## shared/observability/src/airflow_shared/observability/metrics/otel_logger.py: ########## @@ -18,18 +18,21 @@ import datetime import logging -import os import random import warnings from collections.abc import Callable from typing import TYPE_CHECKING from opentelemetry import metrics -from opentelemetry.exporter.otlp.proto.http.metric_exporter import OTLPMetricExporter from opentelemetry.sdk.metrics import MeterProvider -from opentelemetry.sdk.metrics._internal.export import ConsoleMetricExporter, PeriodicExportingMetricReader +from opentelemetry.sdk.metrics._internal.export import ( + ConsoleMetricExporter, + MetricExporter, + PeriodicExportingMetricReader, +) from opentelemetry.sdk.resources import SERVICE_NAME, Resource +from ..otel_env_config import OtelEnvConfig, load_metrics_env_config from .protocols import Timer from .validators import ( Review Comment: It's only for the `shared` module. Because it's hard-linked under `airflow-core` and `task-sdk` and then each one uses its hard-links, it's done to make sure that the imports work the same everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
