xBis7 commented on code in PR #56150: URL: https://github.com/apache/airflow/pull/56150#discussion_r2773960885
########## airflow-core/src/airflow/observability/metrics/otel_logger.py: ########## @@ -26,17 +26,28 @@ def get_otel_logger() -> SafeOtelLogger: + # The config values have been deprecated and therefore, + # if the user hasn't added them to the config, the default values won't be used. + # A fallback is needed to avoid an exception. Review Comment: I've added something similar based on a previous suggestion from @jason810496. In case both the env vars and the airflow configs have been set, there is a warning. https://github.com/xBis7/airflow/blob/a390de3df3ed527ccebfe2c077b767b59fd3dd27/shared/observability/src/airflow_shared/observability/metrics/otel_logger.py#L402-L409 I'll add a similar warning in the else statement, in case just the airflow configs have been set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
