potiuk commented on code in PR #61634:
URL: https://github.com/apache/airflow/pull/61634#discussion_r2779193820
##########
scripts/ci/prek/upgrade_important_versions.py:
##########
@@ -373,6 +373,7 @@ class Quoting(Enum):
),
Quoting.UNQUOTED,
),
+ (re.compile(r"(minimum_prek_version: )('[0-9.abrc]+')", re.MULTILINE),
Quoting.SINGLE_QUOTED),
Review Comment:
As discussed in slack:
I think we should really reserve min-version upgrade in prek when we need
some new feature (like we did with workspace and inline script metadata).
Generally it is not too important for everyone to have the same prek -
because prek is merely executing all our scripts with prek hooks. We can also
do it "from time to time" - i.e. every few months we bump the min version
manually, just to make sure people do not use some ancient version, and we
should still upgrade it in our CI - so that we know things are still working
with the latest version, but I do not think min-version for prek should be
"always" updated when we bump it in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
