potiuk commented on code in PR #61634:
URL: https://github.com/apache/airflow/pull/61634#discussion_r2779205736
##########
scripts/ci/prek/upgrade_important_versions.py:
##########
@@ -373,6 +373,7 @@ class Quoting(Enum):
),
Quoting.UNQUOTED,
),
+ (re.compile(r"(minimum_prek_version: )('[0-9.abrc]+')", re.MULTILINE),
Quoting.SINGLE_QUOTED),
Review Comment:
> Would this then force everyone to keep up with prek version to continue
developing?
Yes. It would. Again - we can do it once in a while (this will make everyone
having to upgrade - they will get the error that they need to upgrade prek, but
we should likely just remove the automated upgrade of it.
So we can merge that one today - but without automation of min_version
upgrade (and possibly with a comment explaining all that so that others are not
tempted to add it again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
